Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print a future warning that poetry-plugin-export will not be installed by default anymore #8562

Merged
merged 1 commit into from
Oct 28, 2023
Merged

print a future warning that poetry-plugin-export will not be installed by default anymore #8562

merged 1 commit into from
Oct 28, 2023

Conversation

radoering
Copy link
Member

@radoering radoering commented Oct 20, 2023 •
edited
Loading

Pull Request Check List

Related-to: #5980, #6441, python-poetry/poetry-plugin-export#240

  • Added tests for changed code.
  • Updated documentation for changed code.

Since I don't see a more elegant solution to proceed with #5980 in the near future, maybe just do it the simple way:
Print a warning for, let's say, 3 minor versions and then just remove the dependency.

With this PR the following deprecation warning will be printed as soon as poetry export is run:

Warning: poetry-plugin-export will not be installed by default in the future.
In order to avoid a breaking change and make your automation forward-compatible, please install poetry-plugin-export explicitly. See https://python-poetry.org/docs/plugins/#using-plugins for details on how to install a plugin.
To disable this warning run 'poetry config warnings.export false'.

@radoering radoering added the impact/docs Contains or requires documentation changes label Oct 20, 2023
@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Deploy preview for website ready!

✅ Preview
https://website-67hvdgmzt-python-poetry.vercel.app

Built with commit 69e9af5.
This pull request is being automatically deployed with vercel-action

@radoering radoering force-pushed the export-deprecation branch 2 times, most recently from 0f5f103 to 6261e37 Compare October 20, 2023 16:51
@radoering radoering mentioned this pull request Oct 20, 2023
Merged
@radoering
print a future warning that poetry-plugin-export will not be installe…
69e9af5 
…d by default anymore and update docs accordingly
@radoering radoering merged commit f59728d into python-poetry:master Oct 28, 2023
33 checks passed
This was referenced Oct 28, 2023
Closed
Merged
Merged
@johnthagen johnthagen mentioned this pull request Nov 7, 2023
Open
MrGreenTea pushed a commit to MrGreenTea/poetry that referenced this pull request Dec 18, 2023
@radoering @MrGreenTea
print a future warning that poetry-plugin-export will not be installe…
5efbc90 
…d by default anymore (python-poetry#8562)
@johnthagen johnthagen mentioned this pull request Feb 23, 2024
Open
@sarisia sarisia mentioned this pull request Feb 26, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neersighted neersighted neersighted approved these changes

Assignees
No one assigned
Labels
impact/docs Contains or requires documentation changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radoering @neersighted